[BugFix] Fix GROUP BY expression resolution in SELECT/HAVING/ORDER BY#5548
Merged
mengweieric merged 1 commit intoJun 16, 2026
Conversation
A SELECT/HAVING/ORDER BY expression matching a GROUP BY expression now resolves to the materialized group-key column via a context-scoped index checked in visitFunction, instead of recomputing it from base fields the aggregation removed (which failed with "Field not found"). Signed-off-by: Chen Dai <daichen@amazon.com>
dai-chen
force-pushed
the
fix/sql-groupby-expression-resolution
branch
from
d9b031f to
6bd1d77
Compare
dai-chen
requested review from
LantaoJin,
RyanL1997,
Swiddis,
acarbonetto,
ahkcs,
anirudha,
joshuali925,
mengweieric,
noCharger,
penghuo,
ps48,
qianheng-aws,
songkant-aws,
vamsimanohar,
ykmr1224 and
yuancu
as code owners
mengweieric
approved these changes
Jun 16, 2026
ahkcs
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A
SELECT,HAVINGorORDER BYexpression matching aGROUP BYexpression (e.g.SELECT LENGTH(name) FROM t GROUP BY LENGTH(name)) failed with "Field [name] not found", because it was re-evaluated against base fields that no longer exist after aggregation. This change makes such an expression reuse the already-computed group-key column. There is no impact on PPL, since PPL grouping clauses only allow field references andspan(never scalar function expressions).SELECT length(name) … GROUP BY LENGTH(name)is not resolved and would require larger changes to canonicalize identifier names during AST building/analysis.Related Issues
Part of #5248
Check List
--signoffor-s.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.